chore(discovery): adjust for EndpointSlices #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This reverts commit 1dbf8d3.
andrewazores
force-pushed
the
endpoint-slices
branch
from
1dbf8d3 to
79d5160
Compare
andrewazores
changed the title
andrewazores
force-pushed
the
endpoint-slices
branch
from
79d5160 to
8d1f864
Compare
Contributor
|
Seems like one of the workflows is still failing after re-running it, is that expected? |
Member
Author
|
I think it needs cryostatio/cryostat#740 to go in first, since the test that's failing will actually deploy a Cryostat instance. This PR changes some permissions so without the corresponding Cryostat change I think it's going to fail at runtime due to the wrong permissions. |
Josh-Matsuoka
approved these changes
Apr 17, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on cryostatio/cryostat#740
Adjusts the Role for EndpointSlices-based discovery rather than the older Endpoints.